[WIP] Bug 1960284: use unsupportedConfigOverrides to set prefer-local annotation by candita · Pull Request #609 · openshift/cluster-ingress-operator

candita · 2021-05-07T03:36:25Z

Change the default ExternalTrafficPolicy from Local to Cluster. In a case where a node that receives traffic doesn’t have a router pod, Cluster permits it to forward to another node with a router pod instead of dropping the traffic.

Allow the old behavior if the IngressController.Spec.UnsupportedConfigOverrides specifies the ExternalTrafficPolicy as Local.

This PR will be used to implement the prefer-local annotation for unsupportedConfigOverrides.

openshift-ci · 2021-05-07T03:36:31Z

@candita: This pull request references Bugzilla bug 1929396, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Bug 1929396: use ExternalTrafficPolicy Cluster by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-05-07T03:36:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [candita]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

smarterclayton · 2021-05-07T12:49:13Z

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-aws/1390515440211464192
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-azure/1390515492527017984

seems to mitigate most disruption (registry may have an issue)

smarterclayton · 2021-05-07T13:55:47Z

/retest

smarterclayton · 2021-05-07T14:13:24Z

Hrm, no, it still has disruption. @candita you need to check what the cause of the router disruption is in the linked runs (i.e. what is happening when disruption_tests: [sig-network-edge] Cluster frontend ingress remain available expand_less fails, which might be there aren't enough instances, which is the minReady PR i have)

test/e2e/operator_test.go

candita · 2021-05-07T21:31:49Z

Hrm, no, it still has disruption. @candita you need to check what the cause of the router disruption is in the linked runs (i.e. what is happening when disruption_tests: [sig-network-edge] Cluster frontend ingress remain available expand_less fails, which might be there aren't enough instances, which is the minReady PR i have)

@smarterclayton, @deads2k - I checked in this log and I see an event that describes "Unreachable -- on openshift.io/frontends-available-test". More details:

[36mINFO[0m[2021-05-07T18:44:57Z] E0507 18:28:12.303105 264 event_broadcaster.go:253] Server rejected event ..., ReportingController:"openshift.io/frontends-available-test", ReportingInstance:"openshift.io/frontends-available-test-e2e-aws-ovn-upgrade-openshift-e2e-test", Action:"detected", Reason:"Unreachable", Regarding:v1.ObjectReference{Kind:"Route", Namespace:"kube-system", Name:"console", UID:"", APIVersion:"", ResourceVersion:"", FieldPath:""}, Related:(*v1.ObjectReference)(nil), Note:"on new connections", Type:"Warning", DeprecatedSource:v1.EventSource{Component:"", Host:""}, DeprecatedFirstTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeprecatedLastTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeprecatedCount:0}': 'Event "console.167cdc366b15ebd8" is invalid: series.count: Invalid value: "": should be at least 2' (will not retry!)

candita · 2021-05-07T23:28:49Z

/retest

smarterclayton · 2021-05-10T16:29:57Z

Note that Azure always preserves source IP when a network level proxy is used, and GCP now supports PROXY in some of their LB modes.

candita · 2021-05-11T13:45:27Z

May 11 02:33:52.083: INFO: cluster upgrade is Failing: Could not update prioritylevelconfiguration "openshift-control-plane-operators" (95 of 695)
...
May 11 02:49:52.087: INFO: cluster upgrade is Failing: Multiple errors are preventing progress:
...

Could not update clusterrolebinding "helm-chartrepos-view" (452 of 695)
Could not update configmap "openshift-insights/service-ca-bundle" (496 of 695)
Could not update deployment "openshift-cluster-node-tuning-operator/cluster-node-tuning-operator" (373 of 695)
Could not update deployment "openshift-ingress-operator/ingress-operator" (330 of 695)
Could not update deployment "openshift-operator-lifecycle-manager/catalog-operator" (519 of 695)
Could not update service "openshift-cluster-storage-operator/cluster-storage-operator-metrics" (426 of 695)
Could not update service "openshift-cluster-storage-operator/csi-snapshot-webhook" (293 of 695)
Could not update serviceaccount "openshift-image-registry/node-ca" (310 of 695)
Could not update servicemonitor "openshift-cluster-samples-operator/cluster-samples-operator" (401 of 695)

/retest

candita · 2021-05-11T17:49:11Z

/retest e2e-upgrade

openshift-ci · 2021-05-11T17:49:25Z

@candita: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

/test e2e-aws
/test e2e-aws-operator
/test e2e-aws-single-node
/test e2e-azure
/test e2e-azure-operator
/test e2e-gcp-operator
/test e2e-gcp-serial
/test e2e-upgrade
/test images
/test unit
/test verify

Use /test all to run the following jobs:

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-serial
pull-ci-openshift-cluster-ingress-operator-master-e2e-upgrade
pull-ci-openshift-cluster-ingress-operator-master-images
pull-ci-openshift-cluster-ingress-operator-master-unit
pull-ci-openshift-cluster-ingress-operator-master-verify

Details

In response to this:

/retest e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2021-05-11T17:49:42Z

/test e2e-upgrade

openshift-ci · 2021-05-20T18:49:48Z

@candita: This pull request references Bugzilla bug 1960284, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 1960284: use unsupportedConfigOverrides to set prefer-local annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2021-05-20T18:49:58Z

/hold

candita · 2021-05-21T14:05:12Z

/bugzilla refresh

openshift-ci · 2021-05-21T14:05:15Z

@candita: This pull request references Bugzilla bug 1960284, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2021-05-21T17:06:34Z

/bugzilla refresh

openshift-ci · 2021-05-21T17:06:40Z

@candita: This pull request references Bugzilla bug 1960284, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2021-05-21T19:10:19Z

pkg/operator/controller/ingress/load_balancer_service.go

-	// (see <https://bugzilla.redhat.com/show_bug.cgi?id=1908758>).
+	// Preserve everything except:
+	// AWS LB health check interval annotation (see <https://bugzilla.redhat.com/show_bug.cgi?id=1908758>) ,
+	// GCP Global Access internal Load Balancer annotation (see <https://bugzilla.redhat.com/show_bug.cgi?id=1908758>), &


https://bugzilla.redhat.com/show_bug.cgi?id=1908758 isn't applicable to GCP Global Access.
Maybe instead we could use https://issues.redhat.com/browse/NE-518 ?

Miciah · 2021-05-25T16:37:27Z

/retitle [WIP] use unsupportedConfigOverrides to set prefer-local annotation

openshift-ci · 2021-05-25T16:37:42Z

@candita: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[WIP] use unsupportedConfigOverrides to set prefer-local annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2021-05-25T16:37:48Z

/retitle [WIP] Bug 1960284: use unsupportedConfigOverrides to set prefer-local annotation

openshift-ci · 2021-05-25T16:38:07Z

@candita: This pull request references Bugzilla bug 1960284, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

[WIP] Bug 1960284: use unsupportedConfigOverrides to set prefer-local annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2021-06-02T01:06:46Z

Thanks for your work on this PR! I borrowed the unsupported config override logic and test code for #622, which supersedes this PR.
/close

openshift-ci · 2021-06-02T01:07:01Z

@Miciah: Closed this PR.

Details

In response to this:

Thanks for your work on this PR! I borrowed the unsupported config override logic and test code for #622, which supersedes this PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-02T01:07:05Z

@candita: This pull request references Bugzilla bug 1960284. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

[WIP] Bug 1960284: use unsupportedConfigOverrides to set prefer-local annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 7, 2021

openshift-ci bot requested a review from lihongan May 7, 2021 03:36

openshift-ci bot requested review from danehans and rfredette May 7, 2021 03:36

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021

Miciah reviewed May 7, 2021

View reviewed changes

test/e2e/operator_test.go Outdated Show resolved Hide resolved

candita force-pushed the BZ-1929396 branch from dd9fcd7 to 0c463ce Compare May 7, 2021 21:05

candita changed the title ~~Bug 1929396: use ExternalTrafficPolicy Cluster by default~~ [WIP] Bug 1929396: use ExternalTrafficPolicy Cluster by default May 10, 2021

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021

Bug 1929396: use ExternalTrafficPolicy Cluster by default

320dc8a

candita force-pushed the BZ-1929396 branch from 0c463ce to 320dc8a Compare May 11, 2021 01:16

candita changed the title ~~[WIP] Bug 1929396: use ExternalTrafficPolicy Cluster by default~~ [WIP] Bug 1960284: use unsupportedConfigOverrides to set prefer-local annotation May 20, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 20, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 21, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 21, 2021

sgreene570 reviewed May 21, 2021

View reviewed changes

openshift-ci bot changed the title ~~[WIP] Bug 1960284: use unsupportedConfigOverrides to set prefer-local annotation~~ [WIP] use unsupportedConfigOverrides to set prefer-local annotation May 25, 2021

openshift-ci bot removed the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label May 25, 2021

openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 25, 2021

openshift-ci bot changed the title ~~[WIP] use unsupportedConfigOverrides to set prefer-local annotation~~ [WIP] Bug 1960284: use unsupportedConfigOverrides to set prefer-local annotation May 25, 2021

openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 25, 2021

openshift-ci bot closed this Jun 2, 2021

Conversation

candita commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented May 7, 2021

Uh oh!

openshift-ci bot commented May 7, 2021

Uh oh!

smarterclayton commented May 7, 2021

Uh oh!

smarterclayton commented May 7, 2021

Uh oh!

smarterclayton commented May 7, 2021

Uh oh!

Uh oh!

candita commented May 7, 2021

Uh oh!

candita commented May 7, 2021

Uh oh!

smarterclayton commented May 10, 2021

Uh oh!

candita commented May 11, 2021

Uh oh!

candita commented May 11, 2021

Uh oh!

openshift-ci bot commented May 11, 2021

Uh oh!

candita commented May 11, 2021

Uh oh!

openshift-ci bot commented May 20, 2021

Uh oh!

candita commented May 20, 2021

Uh oh!

candita commented May 21, 2021

Uh oh!

openshift-ci bot commented May 21, 2021

Uh oh!

candita commented May 21, 2021

Uh oh!

openshift-ci bot commented May 21, 2021

Uh oh!

sgreene570 May 21, 2021

Choose a reason for hiding this comment

Uh oh!

Miciah commented May 25, 2021

Uh oh!

openshift-ci bot commented May 25, 2021

Uh oh!

Miciah commented May 25, 2021

Uh oh!

openshift-ci bot commented May 25, 2021

Uh oh!

Miciah commented Jun 2, 2021

Uh oh!

openshift-ci bot commented Jun 2, 2021

Uh oh!

openshift-ci bot commented Jun 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

candita commented May 7, 2021 •

edited

Loading